Skip to content

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Oct 1, 2025

XIOS implementation of writeDiagnosticTime

Fixes #917
Merges into #928
Will be followed by addressing #929

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

This PR provides an XIOS implementation of writeDiagnosticTime. It completes the set of member functions needed in ParaGridIO_Xios, so the other copied functions are deleted and ifdef-ed out in the header.

Much like in #928, this required a new config section XiosDiagnostic (c.f. XiosForcing).

During my work on this, I noticed #933 and #935.


Test Description

$u$-velocity field written as a diagnostic in the XIOS write test, much like how it is read in the forcing test added in #928.

Changes to XIOS read test for consistency.


Documentation Impact

Diagnostics are mentioned in the XIOS section of the docs.


Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • This change conforms to the conventions described in the README

@jwallwork23 jwallwork23 self-assigned this Oct 1, 2025
@jwallwork23 jwallwork23 added enhancement New feature or request ICCS Tasks or reviews for the ICCS team labels Oct 1, 2025
@jwallwork23 jwallwork23 marked this pull request as ready for review October 1, 2025 15:30
Base automatically changed from issue916_xios-read-forcing-time-static to develop October 2, 2025 12:35
@jwallwork23
Copy link
Contributor Author

I just pushed an extra commit 0e09b2c that checks the filename is correct whenever one of the reading and writing member functions of ParaGridIO are called. Note that this argument was previously unused (included only to ensure a consistent API with the non-XIOS version.)

This was referenced Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ICCS Tasks or reviews for the ICCS team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XIOS implementation of writeDiagnosticTime

1 participant